On 08/09/2022 17:20, Luca Ceresoli wrote: > Hello Krzysztof, > > thank you for reviewing my patches. > > On Thu, 8 Sep 2022 13:49:34 +0200 > Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx> wrote: > >> On 07/09/2022 16:21, luca.ceresoli@xxxxxxxxxxx wrote: >>> From: Luca Ceresoli <luca.ceresoli@xxxxxxxxxxx> > > [...] > >>> +properties: >>> + compatible: >>> + const: rockchip,rk3308-audio-graph-card >> >> Is "graph" part of device name or you just put it there because of other >> schema? > > Indeed this comes from the "audio-graph-card" compatible string. > >> The compatible should reflect the device name, not some other >> pieces in Linux or in bindings. > > Would it be OK to rename it to rockchip,rk3308-audio-card (i.e. drop > the "graph-" infix)? > > Fixes for the other comments you made to this and the other patches are > already queued for v2. Yes, either rockchip,rk3308-audio-card or rockchip,rk3308-audio Best regards, Krzysztof
