On 2022-06-14 6:51 PM, Pierre-Louis Bossart wrote:
If it ain't broke don't fix it.
to clarify: the HDaudio mode works just fine, there are currently zero
issues or missing functionality reported by users.
Not much of a fan of the last statement. I believe challenging status
quo is the right thing to do. We do not want to bloat the kernel with
unnecessary quirks.
The broadwell-rt286 UCM is part of alsa-ucm-conf repo for years now.
The hardware supports two modes (HDaudio and DSP + I2S), the former has
been in use without any issues for years.
Even if you make DSP + I2S the default, you've got to leave HDaudio as a
fallback, so there would be no change at the kernel level.
It' very very hard to remove stuff, and in this case there is limited
evidence that distributions use the DSP + I2S mode. You could deprecate
the ACPI_OVERRIDE but you've got to leave time for distributions to switch.
Challenging the status quo is great, but let's keep downstream in mind,
shall we?
The only option we removed was Medfield several years ago, but we had
clear evidence that no one would be affected by such a change in the
upstream kernel.
If the entry has to stay for the fallback reasons, then it can't be just
removed. And if so, regardless of the default it's going to be there -
no point in providing a patch.
Thanks for the feedback!
Regards,
Czarek
