On Mon, 28 Mar 2022 17:31:51 +0100, Mark Brown wrote: > On Sun, Mar 27, 2022 at 04:21:38PM +0800, Xiaomeng Tong wrote: > > > case snd_soc_dapm_pre: > > - if (!w->event) > > + if (!w->event) { > > list_for_each_entry_safe_continue(w, n, list, > > power_list); > > + break; > > + } > > This doesn't make much sense. The intent here seems to clearly be to > continue; the loop but this doesn't do that - instead it appears that > continue doesn't actually do the equivalent of a continue but rather > skips over an entry. This should instead be replaced with a plain > continue statement. > Yes, you are right. Sorry for a slip of the pen in commit message: should be "to *continue* the outer list_for_each_entry_safe() loop" not "to break ...". I have resend a PATCH v2 for the fix as you suggested, and cc you. Thank you. > THe naming of _continue() needs fixing I think - it's just asking to be > a bug. Fortunately there's very few users. -- Xiaomeng Tong