Re: [PATCH v3 10/17] ASoC: Intel: avs: Add basefw runtime-parameter requests

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 2022-03-07 6:06 PM, Ranjani Sridharan wrote:
On Mon, 2022-03-07 at 18:02 +0100, Cezary Rojewski wrote:
What could make it simpler is if you allocate MAX IPC size for
payload
in this function and then copy the right size in the
avs_ipc_get_large_config(). payload_size tells you that information
anyway right?




As stated, there is no clear winner here - you had to repeat such
code

for every getter.



Since we are getting payload_size already, retrieving payload itself
is

just fine.

OK, can you please add a comment to state this in the patch so the
reviewer doesnt have to track down where this memory is allocated?


Sure, will add in v4.



[Index of Archives]     [ALSA User]     [Linux Audio Users]     [Pulse Audio]     [Kernel Archive]     [Asterisk PBX]     [Photo Sharing]     [Linux Sound]     [Video 4 Linux]     [Gimp]     [Yosemite News]

  Powered by Linux