Re: [PATCH v3 09/17] ASoC: Intel: avs: Add ROM requests

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 2022-03-04 5:26 PM, Ranjani Sridharan wrote:
On Fri, 2022-03-04 at 15:57 +0100, Cezary Rojewski wrote:
ROM requests are messages initiated by Host to alter firmware early
boot
process. They specify whether the next boot should be a fresh start
or if
IMR can be used to speed things up.

Signed-off-by: Amadeusz Sławiński <
amadeuszx.slawinski@xxxxxxxxxxxxxxx>
Signed-off-by: Cezary Rojewski <cezary.rojewski@xxxxxxxxx>
---
  sound/soc/intel/avs/messages.c | 18 ++++++++++++++++++
  sound/soc/intel/avs/messages.h | 14 ++++++++++++++
  2 files changed, 32 insertions(+)

diff --git a/sound/soc/intel/avs/messages.c
b/sound/soc/intel/avs/messages.c
index e8f441b28d71..f7d00e541323 100644
--- a/sound/soc/intel/avs/messages.c
+++ b/sound/soc/intel/avs/messages.c
@@ -12,6 +12,24 @@
#define AVS_CL_TIMEOUT_MS 5000 +int avs_ipc_set_boot_config(struct avs_dev *adev, u32 dma_id, u32
purge)
Does purge set to true indicate a fresh boot and a false indicate IMR
restore? A description would help.


Indeed, purge indicates a fresh boot.

I believe flow is explained well by the layout of the calling functions, local variable naming and step-ordering which are found later in the series.


Regards,
Czarek



[Index of Archives]     [ALSA User]     [Linux Audio Users]     [Pulse Audio]     [Kernel Archive]     [Asterisk PBX]     [Photo Sharing]     [Linux Sound]     [Video 4 Linux]     [Gimp]     [Yosemite News]

  Powered by Linux