Re: [PATCH v3 03/17] ASoC: Intel: Introduce AVS driver

[Cezary Rojewski <cezary.rojewski@xxxxxxxxx>]

On 2022-03-04 4:51 PM, Ranjani Sridharan wrote:

...

> > +#ifndef __SOUND_SOC_INTEL_AVS_H
> > +#define __SOUND_SOC_INTEL_AVS_H
> > +
> > +#include <linux/device.h>
> > +#include <sound/hda_codec.h>
> > +
> > +struct avs_dev;
> > +
> > +struct avs_dsp_ops {
> > +	int (* const power)(struct avs_dev *, u32, bool);
> > +	int (* const reset)(struct avs_dev *, u32, bool);
> > +	int (* const stall)(struct avs_dev *, u32, bool);
> > +};
> > +
> > +#define avs_dsp_op(adev, op, ...) \
> > +	((adev)->spec->dsp_ops->op(adev, ## __VA_ARGS__))
> > +
> > +#define avs_platattr_test(adev, attr) \
> > +	((adev)->spec->attributes & AVS_PLATATTR_##attr)
> AVS_PLATATTR_* don't seem to be defined in this patch?
>
> Thanks,
> Ranjani

Thanks for feedback! Consider dropping the unnecessary bits so it is 
easier to navigate through your responses.

Yes, AVS_PLATATTR_ constants were split from this patch. This patch 
defines just base API instead.


Regards,
Czarek