On Wed, Dec 29, 2021 at 10:11:57AM -0300, Fabio Estevam wrote: > On Wed, Dec 29, 2021 at 9:43 AM Mark Brown <broonie@xxxxxxxxxx> wrote: > > There might be more out of tree users of course - there's no requirement > > for people to upstream their DTs. Probably better to play it safe. > If someone correctly describes the gpio_reset as active-low, then the > driver will not work. > If there is any out-of-tree user of the gpio_reset property, they are > passing the incorrect polarity in the device tree > and things are working by pure luck. (wrong polarity in dts + wrong > polarity handling in the driver = working state) To be honest I think the transparent polarity handling in the GPIO bindings was a mistake, it's caused no end of problems especially with signals like this which are active low - it's a nasty gotcha for conversion to descriptors. > Ok, if this can't be fixed, then let's drop patches 2 and 3, which is > unfortunate. Why drop patch 3?
Attachment:
signature.asc
Description: PGP signature
