Hi Charles, On Wed, Dec 29, 2021 at 8:54 AM Charles Keepax <ckeepax@xxxxxxxxxxxxxxxxxxxxx> wrote: > Hmm... I might defer to Mark on this one. I totally agree your > new code is more correct, however, I would have a slight worry > about existing device trees not correctly specifying the GPIO. As > in if existing systems had been specifying the GPIO correctly > they are presumably currently broken. But I am not sure what the > obvious solution would be, and I don't really have a good feel > for how widely used this part is. I could not find a single user of the cs4265 in linux-next. The board I have does not connect a GPIO to the CS4264 reset line, so I am not affected by it. Cheers