On 2021-12-16 5:29 PM, Pierre-Louis Bossart wrote:
I don't really see the point about the number of fields, this is a
generic descriptor used for I2S/SoundWire devices so mechanically there
are things are are not used in all platforms.
Another example is the quirks field, it's only meant to be used when
there's actually a quirk.
Note that I am planning to remove the sof_fw_filename field since it's
redundant with what is part of the PCI descriptor, but the topology will
remain there: it has to match with the machine driver.
That's why no new struct is declared. Simply the tables are moved
locally, and there is nothing wrong with that. Cohesiveness and
readability outweighs the duplication of ACPI _HID.
If I follow your logic, I could move all the tables for glk, cnl, cfl,
cml, icl, jsl, tgl, ehl, adl into the SOF driver. That really doesn't
seem sensible.
Hmm.. doesn't it really? Are the glk/cnl/cfl/cml/icl/jsl/tgl/ehl/adl
tables "common" for the Intel audio drivers? There are not used by
anything except for SOF. It seems reasonable to have them present
locally too. SOF solution becomes more cohesively organized in such
case, just like catpt is after this patch.
Regards,
Czarek
