On 2021-12-16 3:11 PM, Pierre-Louis Bossart wrote:
The intent of soc-acpi files is to establish a match between ACPI _HID
and machine driver, this is now duplicated, and it makes limited sense
to add machine driver dependencies in a platform driver.
Nothing was broken with the existing code.
Hello,
Yes, nothing is broken in the existing code. The intention is different
- be cohesive about what is actually used by the driver.
PCI-ids table is duplicated already for the Intel audio drivers. And
it's OK to do so - one knows which ids are covered by given driver and
how. Here, it's clear that haswell_machines are only used by
catpt-driver and so are some fields for broadwell_machines. In time I
believe that we will be able to reduce the number of fields for struct
snd_soc_acpi_mach i.e. have a single fw_filename and single
tplg_filename field without some driver-specific duplicates.
About the last, there could be a case where no topology file is
available for certain configuration and given entry should not be taken
into account. While catpt-driver does not make use of soc-topology
feature, that isn't true for other drivers.
Regards,
Czarek
