> > Takashi Iwai napsal(a): >> At Tue, 18 Mar 2008 07:56:11 +0100, >> Pavel Hofman wrote: >>> Takashi Iwai wrote: >>>> At Mon, 17 Mar 2008 16:50:39 +0100, >>>> Pavel Hofman wrote: >>>> >>>> Well, then we'll need to find some point to compromise. Could you >>>> repost the patch after reducing the callbacks again? >>>> >>>> I'll have also no time from the next week at all -- will be on >>>> vacation for three weeks. So, let's kick it out soonish :) >>>> >>> Hi, >>> >>> I am sorry, the previous patch had some debugs enabled. Here is a fixed >>> patch. >>> >>> Thanks a lot. >>> >>> Pavel. >>> >>> >>> Signed-off-by: Pavel Hofman <dustin at seznam.cz> >>> >>> * moving most of clock-specific code to card-specific routines >>> * support for ESI Juli >>> * to-be-researched - monitoring of analog/digital inputs >> Thanks. Now I checked the patch and found it much better now. >> However, I still think the get_rate_index can be omitted by checking >> the index from the rate list dynamically. This looks inefficent but >> improves the readability and reduces the code size better. Moreover, >> the snd_pcm_hw's aren't needed to be prepared for each type. >> >> Below is my revised patch. With this patch, ice->hw_rates must be >> non-NULL and this is referred in many places. It cleans up >> *_internal_clock*() nicely. >> > Takashi, thanks for commiting the patch. I just noticed the final patch does not change the native rates flags in snd_vt1724_playback_pro for juli, keeping the unsupported values 8000 - 12000 in the flags. I guess if 8kHz rate is played via plughw, plughw will not resample and juli will switch to gpios = 0, corresponding to 32kHz. I can test in the evening, but this is very likely. Pavel. _______________________________________________ Alsa-devel mailing list Alsa-devel@xxxxxxxxxxxxxxxx http://mailman.alsa-project.org/mailman/listinfo/alsa-devel
