At Mon, 17 Mar 2008 09:57:49 +0100, Pavel Hofman wrote: > > Takashi Iwai wrote: > > At Sun, 16 Mar 2008 13:57:24 +0100, > > Pavel Hofman wrote: > >> Hi Takashi, > > > > I feel there are too many additional callbacks in your patch. > > Since we don't need too subtle tuning, can we simplify this? > > There are only two callbacks which Juli does not redefine. These could > be removed. Though I felt it was cleaner to have all the clock-specific > stuff potentially redefinable for other cards. > > I did not want to copy/paste any algorithmical code from ice1724.c to > juli.c as it complicates future maintenance. Now, the vt1724 code in > ice1724.c is pretty much about general algorhitms, specific routines are > in stdclock_... I tested the original clock with Prodigy192 which > provided testing analog/SPDIF signals. There are no functional changes. I see the point that you want to make it generic. But, too many callbacks, in other words, too many tuning parameters make the code difficult to follow. It's a question of balance. Takashi _______________________________________________ Alsa-devel mailing list Alsa-devel@xxxxxxxxxxxxxxxx http://mailman.alsa-project.org/mailman/listinfo/alsa-devel
