On 10/15/21 8:34 AM, Chris Chiu wrote: > The jd_src of RT711 which is initialized in rt711/rt711_sdca_init > will be overridden by rt711/rt711_sdca_add_codec_device_props when > the sof_sdw_quirk is not RT711_JD_NULL. It will force the JD mode > to RT711_JD1 and cause confusion while debugging the JD mode of > the boards without quirk. Initialize sof_sdw_quirk with RT711_JD_NULL > to honor the jd_src value in rt711/rt711_sdca init. Not able to follow what the "confusion while debugging the JD mode of the boards without quirk" is. You need a DMI quirk or need to override the default quirk with the kernel module parameter. This also has the side effect of breaking ALL existing DMI quirks implicitly using JD1... > Signed-off-by: Chris Chiu <chris.chiu@xxxxxxxxxxxxx> > --- > sound/soc/intel/boards/sof_sdw.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/sound/soc/intel/boards/sof_sdw.c b/sound/soc/intel/boards/sof_sdw.c > index 6b06248a9327..d05c0565e09c 100644 > --- a/sound/soc/intel/boards/sof_sdw.c > +++ b/sound/soc/intel/boards/sof_sdw.c > @@ -15,7 +15,7 @@ > #include "sof_sdw_common.h" > #include "../../codecs/rt711.h" > > -unsigned long sof_sdw_quirk = RT711_JD1; > +unsigned long sof_sdw_quirk = RT711_JD_NULL; > static int quirk_override = -1; > module_param_named(quirk, quirk_override, int, 0444); > MODULE_PARM_DESC(quirk, "Board-specific quirk override"); >
