On Fri, Oct 15, 2021 at 02:36:11PM +0100, Richard Fitzgerald wrote: > Driver remove() should assert RESET and disable the supplies. > Previously this assumed that calling pm_runtime_suspend() would result > in a call to cs42l42_runtime_suspend() to power-down. This isn't > guaranteed - pm_runtime can be disabled. > pm_runtime_suspend(&i2c_client->dev); > pm_runtime_disable(&i2c_client->dev); > > + gpiod_set_value_cansleep(cs42l42->reset_gpio, 0); > + regulator_bulk_disable(ARRAY_SIZE(cs42l42->supplies), cs42l42->supplies); Won't this end up with an extra disable of the regulators if they're already disabled?
Attachment:
signature.asc
Description: PGP signature
