On Tue, Jun 15, 2021 at 02:06:30PM +0200, Claudius Heine wrote: > On 2021-06-15 13:54, Mark Brown wrote: > > On Tue, Jun 15, 2021 at 11:49:30AM +0200, Claudius Heine wrote: > > > With this change it will be possible to add different code paths for > > > similar devices. > > > - { "tlv320aic32x4", 0 }, > > > - { "tlv320aic32x6", 1 }, > > > + { "tlv320aic32x4", (kernel_ulong_t)AIC32X4_TYPE_AIC32X4 }, > > > + { "tlv320aic32x6", (kernel_ulong_t)AIC32X4_TYPE_AIC32X6 }, > > > { /* sentinel */ } > > It appears that the device already supports multiple variants? > Those values aren't used anywhere as far as I can see. The point here is that you need a better changelog, the driver clearly already supports multiple devices so we need a few more words to explain what this is doing.
Attachment:
signature.asc
Description: PGP signature