Re: [PATCH 1/3] ASoC: tlv320aic32x4: prepare driver for different device variants

[Claudius Heine <ch@xxxxxxx>]

Hi Mark,

On 2021-06-15 13:54, Mark Brown wrote:
> On Tue, Jun 15, 2021 at 11:49:30AM +0200, Claudius Heine wrote:
>
> > With this change it will be possible to add different code paths for
> > similar devices.
>
> >   static const struct i2c_device_id aic32x4_i2c_id[] = {
> > -	{ "tlv320aic32x4", 0 },
> > -	{ "tlv320aic32x6", 1 },
> > +	{ "tlv320aic32x4", (kernel_ulong_t)AIC32X4_TYPE_AIC32X4 },
> > +	{ "tlv320aic32x6", (kernel_ulong_t)AIC32X4_TYPE_AIC32X6 },
> >   	{ /* sentinel */ }
>
> It appears that the device already supports multiple variants?

Those values aren't used anywhere as far as I can see.

regards,
Claudius