Re: [PATCH] usb-audio: Add support for Denon DN-X1600

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, 08 Jun 2021 09:15:01 +0200,
Damien Zammit wrote:
> --- a/sound/usb/pcm.c
> +++ b/sound/usb/pcm.c
> @@ -197,6 +197,10 @@ int snd_usb_init_pitch(struct snd_usb_audio *chip,
>  	if (!(fmt->attributes & UAC_EP_CS_ATTR_PITCH_CONTROL))
>  		return 0;
>  
> +	/* Denon DN-X1600 doesn't properly handle this, bail out too */
> +	if (chip->usb_id == USB_ID(0x154e, 0x500e))
> +		return 0;
> +

Do we need this part?  If this is required, it means that the
audioformat sets UAC_EP_CS_ATTR_PITCH_CONTROL incorrectly.

Also, at the next time, please put maintainers to Cc.  This will avoid
overlooks from maintainers side.


thanks,

Takashi



[Index of Archives]     [ALSA User]     [Linux Audio Users]     [Pulse Audio]     [Kernel Archive]     [Asterisk PBX]     [Photo Sharing]     [Linux Sound]     [Video 4 Linux]     [Gimp]     [Yosemite News]

  Powered by Linux