On Tue, Jun 08, 2021 at 05:07:13PM +0100, Mark Brown wrote:
> One of the fixes reverted as part of the UMN fallout was actually fine,
> however rather than undoing the revert the process that handled all this
> stuff resulted in a patch which attempted to add extra error checks
> instead. Unfortunately this new change wasn't really based on a good
> understanding of the subsystem APIs and bypassed the usual patch flow
> without ensuring it was reviewed by people with subsystem knowledge and
> was merged as a fix rather than during the merge window.
>
> The effect of the new fix is to upgrade what were previously warnings on
> static data in the code to hard errors on that data. If this actually
> happens then it would break existing systems, if it doesn't happen then
> the change has no effect so this was not a safe change to apply as a fix
> to the release candidates. Since the new code has not been tested and
> doesn't in practice improve error handling revert it instead, and also
> drop the original revert since the original fix was fine. This takes
> the driver back to what it was in -rc1.
>
> Fixes: 5e70b8e22b64e ("ASoC: rt5645: add error checking to rt5645_probe function")
> Fixes: 1e0ce84215dbf ("Revert "ASoC: rt5645: fix a NULL pointer dereference")
> Signed-off-by: Mark Brown <broonie@xxxxxxxxxx>
> Cc: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx>
> Cc: Phillip Potter <phil@xxxxxxxxxxxxxxxx>
> ---
> sound/soc/codecs/rt5645.c | 49 +++++++++------------------------------
> 1 file changed, 11 insertions(+), 38 deletions(-)
Reviewed-by: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx>
