Re: [PATCH] Convert non-SoC PXA2xx AC97 driver to clock API

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, Feb 21, 2008 at 03:27:41PM +0000, Russell King - ARM Linux wrote:

> Same comments as previous patch.

...

> This might disable the clock more times than its been enabled, particularly
> if the getting of ac97_clk fails.

Indeed - there's no need to disable it at all since it's only enabled
during a reset.

Thanks, I'll resubmit with these fixed.
_______________________________________________
Alsa-devel mailing list
Alsa-devel@xxxxxxxxxxxxxxxx
http://mailman.alsa-project.org/mailman/listinfo/alsa-devel

[Index of Archives]     [ALSA User]     [Linux Audio Users]     [Kernel Archive]     [Asterisk PBX]     [Photo Sharing]     [Linux Sound]     [Video 4 Linux]     [Gimp]     [Yosemite News]

  Powered by Linux