On Thu, Feb 21, 2008 at 03:26:13PM +0000, Russell King - ARM Linux wrote:
> On Tue, Feb 19, 2008 at 04:04:17PM +0000, Mark Brown wrote:
> ret = PTR_ERR(ac97conf_clk);
> Always propagate error codes.
I've fixed both of these.
> > + err_irq:
> > + GCR |= GCR_ACLINK_OFF;
> > + if (ac97_clk) {
> > + clk_disable(ac97_clk);
> > + clk_put(ac97_clk);
> > + ac97_clk = NULL;
> > }
> Under what circumstance will we get here with a non-NULL ac97_clk?
We can't - the check is redundant now due to the addition of IRQ. Fixed
as well.
Thanks for the review, I'll resubmit.
_______________________________________________
Alsa-devel mailing list
Alsa-devel@xxxxxxxxxxxxxxxx
http://mailman.alsa-project.org/mailman/listinfo/alsa-devel
