Hi,
On 5/22/21 8:09 PM, Andy Shevchenko wrote:
> On Fri, May 21, 2021 at 11:23 PM Hans de Goede <hdegoede@xxxxxxxxxx> wrote:
>>
>> Move the check for a second ACPI device for BOSC0200 ACPI fwnodes into
>> a new bmc150_acpi_dual_accel_probe() helper function.
>>
>> This is a preparation patch for adding support for a new "DUAL250E" ACPI
>> Hardware-ID (HID) used on some devices.
>
> ...
>
>> +#ifdef CONFIG_ACPI
>> +static const struct acpi_device_id bmc150_acpi_dual_accel_ids[] = {
>> + {"BOSC0200"},
>
>> + { },
>
> I guess it is a good chance to drop a comma.
Ack, will drop for v2.
Regards,
Hans
>
>> +};
>
> ...
>
>> + if (!IS_ERR(second_dev))
>> + bmc150_set_second_device(client, second_dev);
>
> I would comment on the pattern here, but I have noticed that this code
> is changed in the further patches anyway.
>
