Re: [PATCH v3 02/11] ALSA: firewire-lib/motu: use int type for the value of bitwise OR with enumerator-constant

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, May 18, 2021 at 09:02:54AM +0200, Takashi Iwai wrote:
> On Tue, 18 May 2021 04:43:17 +0200,
> Takashi Sakamoto wrote:
> > 
> > It brings some inconvenience in practice to use enumerated type for
> > variable to which bitwise OR with enumerator constant is assigned.
> > 
> > This commit replaces declarations of enumerated type with int type.
> 
> Better to use unsigned int for bit flags.  Otherwise the highest bit
> becomes harder to use.

I can't imagine such situation that the signed value causes issue. Would
I request actual example with such issue? At least, the highest bit is
still available as bit even if the value is negative by assigning
0x80000000...


Regards

Takashi Sakamoto



[Index of Archives]     [ALSA User]     [Linux Audio Users]     [Pulse Audio]     [Kernel Archive]     [Asterisk PBX]     [Photo Sharing]     [Linux Sound]     [Video 4 Linux]     [Gimp]     [Yosemite News]

  Powered by Linux