Re: [PATCH] sound: rawmidi: Add framing mode

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, 17 May 2021 11:04:28 +0200,
Takashi Iwai wrote:
> 
> On Sat, 15 May 2021 09:15:33 +0200,
> David Henningsson wrote:
> > 
> > This commit adds a new framing mode that frames all MIDI data into
> > 32-byte frames with a timestamp.
> > 
> > The main benefit is that we can get accurate timestamps even if
> > userspace wakeup and processing is not immediate.
> > 
> > Testing on a Celeron N3150 with this mode has a max jitter of 2.8 ms,
> > compared to the in-kernel seq implementation which has a max jitter
> > of 5 ms during idle and much worse when running scheduler stress tests
> > in parallel.
> > 
> > Signed-off-by: David Henningsson <coding@xxxxxxxx>
> > ---
> > 
> > Hi, it's been a while. Both because I've been busy with things that needed
> > to take priority, and because I wanted to do a little more than just compile
> > testing it before submitting; hopefully this one is mergable.
> > 
> > That testing showed that I needed to change from "u8" to "__u8" in the headers.
> > Other than that I think it is just the changes that Takashi Iwai pointed out in v6.
> 
> Thanks, it looks good to me.
> 
> If anyone has no objection, I'm going to merge this soon later.

Now applied.

Could you submit the corresponding patches for alsa-lib, too?


Thanks!

Takashi



[Index of Archives]     [ALSA User]     [Linux Audio Users]     [Pulse Audio]     [Kernel Archive]     [Asterisk PBX]     [Photo Sharing]     [Linux Sound]     [Video 4 Linux]     [Gimp]     [Yosemite News]

  Powered by Linux