On 2021/4/2 4:20, Rob Herring wrote: > On Wed, Mar 31, 2021 at 05:16:16PM +0800, Zhen Lei wrote: >> Currently, if there are more than two ports, or if there is only one port >> but other properties(such as "#address-cells") is required, these ports >> are placed under the "ports" node. So add the schema of property "ports". > > A given binding should just use 'ports' or 'port' depending on it's > need. Supporting both forms is needless complexity. Right, I'll adjust this patch again. > >> Otherwise, warnings similar to the following will be reported: >> arch/arm64/boot/dts/renesas/r8a774a1-beacon-rzg2m-kit.dt.yaml: \ >> sound@ec500000: 'ports' does not match any of the regexes: \ >> '^rcar_sound,ctu$', '^rcar_sound,dai$', '^rcar_sound,dvc$', ... >> >> Signed-off-by: Zhen Lei <thunder.leizhen@xxxxxxxxxx> >> --- >> Documentation/devicetree/bindings/sound/renesas,rsnd.yaml | 5 +++++ >> 1 file changed, 5 insertions(+) >> >> diff --git a/Documentation/devicetree/bindings/sound/renesas,rsnd.yaml b/Documentation/devicetree/bindings/sound/renesas,rsnd.yaml >> index 384191ee497f534..a42992fa687d3f3 100644 >> --- a/Documentation/devicetree/bindings/sound/renesas,rsnd.yaml >> +++ b/Documentation/devicetree/bindings/sound/renesas,rsnd.yaml >> @@ -115,6 +115,11 @@ properties: >> $ref: audio-graph-port.yaml# >> unevaluatedProperties: false >> >> + ports: > > $ref: /schemas/graph.yaml#/properties/ports OK, thanks > >> + patternProperties: >> + '^port@[0-9]': >> + $ref: "#/properties/port" > > Then this should be: $ref: audio-graph-port.yaml# OK, thanks > > Also, what each port is should be defined, but that's a separate > problem. > >> + >> # use patternProperties to avoid naming "xxx,yyy" issue >> patternProperties: >> "^rcar_sound,dvc$": >> -- >> 1.8.3 >> >> > > . >
