Re: [PATCH 5/5] SOC Codecs: TLV320AIC3X add SPI: configuration and compile

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Jiri,

Thank you for the patch! Yet something to improve:

[auto build test ERROR on asoc/for-next]
[also build test ERROR on v5.12-rc6 next-20210406]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/0day-ci/linux/commits/Jiri-Prchal/SOC-Codecs-TLV320AIC3X-add-SPI-support/20210406-185528
base:   https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next
config: arc-allyesconfig (attached as .config)
compiler: arceb-elf-gcc (GCC) 9.3.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://github.com/0day-ci/linux/commit/8001328cfb49d6387002a8314bc25241e46a969d
        git remote add linux-review https://github.com/0day-ci/linux
        git fetch --no-tags linux-review Jiri-Prchal/SOC-Codecs-TLV320AIC3X-add-SPI-support/20210406-185528
        git checkout 8001328cfb49d6387002a8314bc25241e46a969d
        # save the attached .config to linux build tree
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=arc 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@xxxxxxxxx>

All errors (new ones prefixed by >>):

>> sound/soc/codecs/tlv320aic3x-i2c.c:61:32: error: expected '}' before ')' token
      61 |   .of_match_table = aic3x_of_id),
         |                                ^
   sound/soc/codecs/tlv320aic3x-i2c.c:59:12: note: to match this '{'
      59 |  .driver = {
         |            ^
>> sound/soc/codecs/tlv320aic3x-i2c.c:61:32: error: expected '}' before ')' token
      61 |   .of_match_table = aic3x_of_id),
         |                                ^
   sound/soc/codecs/tlv320aic3x-i2c.c:58:45: note: to match this '{'
      58 | static struct i2c_driver aic3x_i2c_driver = {
         |                                             ^
>> sound/soc/codecs/tlv320aic3x-i2c.c:61:32: error: expected ',' or ';' before ')' token
      61 |   .of_match_table = aic3x_of_id),
         |                                ^
>> sound/soc/codecs/tlv320aic3x-i2c.c:62:3: error: expected identifier or '(' before ',' token
      62 |  },
         |   ^
   sound/soc/codecs/tlv320aic3x-i2c.c:38:35: warning: 'aic3x_i2c_id' defined but not used [-Wunused-const-variable=]
      38 | static const struct i2c_device_id aic3x_i2c_id[] = {
         |                                   ^~~~~~~~~~~~
   sound/soc/codecs/tlv320aic3x-i2c.c:33:12: warning: 'aic3x_i2c_remove' defined but not used [-Wunused-function]
      33 | static int aic3x_i2c_remove(struct i2c_client *i2c)
         |            ^~~~~~~~~~~~~~~~
   sound/soc/codecs/tlv320aic3x-i2c.c:20:12: warning: 'aic3x_i2c_probe' defined but not used [-Wunused-function]
      20 | static int aic3x_i2c_probe(struct i2c_client *i2c, const struct i2c_device_id *id)
         |            ^~~~~~~~~~~~~~~


vim +61 sound/soc/codecs/tlv320aic3x-i2c.c

eab5358b511ef2 Jiri Prchal 2021-04-06  57  
eab5358b511ef2 Jiri Prchal 2021-04-06  58  static struct i2c_driver aic3x_i2c_driver = {
eab5358b511ef2 Jiri Prchal 2021-04-06  59  	.driver = {
eab5358b511ef2 Jiri Prchal 2021-04-06  60  		.name = "tlv320aic3x",
eab5358b511ef2 Jiri Prchal 2021-04-06 @61  		.of_match_table = aic3x_of_id),
eab5358b511ef2 Jiri Prchal 2021-04-06 @62  	},
eab5358b511ef2 Jiri Prchal 2021-04-06  63  	.probe = aic3x_i2c_probe,
eab5358b511ef2 Jiri Prchal 2021-04-06  64  	.remove = aic3x_i2c_remove,
eab5358b511ef2 Jiri Prchal 2021-04-06  65  	.id_table = aic3x_i2c_id,
eab5358b511ef2 Jiri Prchal 2021-04-06  66  };
eab5358b511ef2 Jiri Prchal 2021-04-06  67  

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@xxxxxxxxxxxx

Attachment: .config.gz
Description: application/gzip


[Index of Archives]     [ALSA User]     [Linux Audio Users]     [Pulse Audio]     [Kernel Archive]     [Asterisk PBX]     [Photo Sharing]     [Linux Sound]     [Video 4 Linux]     [Gimp]     [Yosemite News]

  Powered by Linux