This fixes a longstanding issue that prevented jack detection from working on systems with the ALC3263 codec, such as the Dell XPS 13 9343, when using I2S mode for audio (instead of HDA mode). There is currently an ACPI quirk for the Dell XPS 13 9343 that forces it to use HDA mode instead of I2S mode, because jack detection did not work. See: https://lore.kernel.org/alsa-devel/CAPeXnHv07HkvcHrYFmZMr8OTp7U7F=k_k=LPYnUtp89iPn2d2Q@xxxxxxxxxxxxxx/ There are very likely codec fixups for the HDA driver which should be added to the I2S codec driver, to attempt to achieve parity. Commit 394c97f824fa ("ALSA: hda/realtek - Change EAPD to verb control") describes an issue that still seems to be present in the I2S codec driver, for example. In any case this change should move closer to allowing the Dell XPS 13 9343 to default to I2S mode; and it resolves this issue for systems which use I2S mode now, including the Dell Latitude 7350 and the Dell Venue 11 Pro 7140. BugLink: https://bugzilla.kernel.org/show_bug.cgi?id=114171 BugLink: https://bugzilla.kernel.org/show_bug.cgi?id=150601 BugLink: https://bugzilla.kernel.org/show_bug.cgi?id=205961 Signed-off-by: David Ward <david.ward@xxxxxxxxxx> David Ward (3): ASoC: rt286: Make RT286_SET_GPIO_* readable and writable ASoC: rt286: Handle all devices with ALC3263 codec ASoc: rt286: Handle headphones in combo jack correctly sound/soc/codecs/rt286.c | 29 +++++++++++++++++++---------- 1 file changed, 19 insertions(+), 10 deletions(-) -- 2.30.1
