Hey,
On Mon, 4 Jan 2021, Kai-Heng Feng wrote:
> System takes a very long time to suspend after commit 215a22ed31a1
> ("ALSA: hda: Refactor codec PM to use direct-complete optimization"):
> [ 90.065964] PM: suspend entry (s2idle)
the patch itself looks good, but can you explain a bit more in what
conditions you hit the delay?
I tried to reproduce the delay on multiple systems (with tip of
tiwai/master), but with no luck. I can see hda_jackpoll_work() called, but
at this point runtime pm has been disabled already (via
__device_suspend()) and snd_hdac_is_power_on() will return true even when
pm_runtime_suspended() is true as well (which is expected as runtime-pm is
disabled at this point for system suspend). End result is codec is not
powered up in hda_jackpoll_work() and suspend is not delayed.
The patch still seems correct. You would hit the problem you describe if
jackpoll_interval was set to a non-zero value (not the case on most
systems supported by SOF, but still a possibility). I'm still curious how
you hit the problem. At minimum, we are missing a scenario in our testing.
Br, Kai
