At Thu, 24 Jan 2008 13:44:54 -0200, Herton Ronaldo Krzesinski wrote: > > Em Thursday 24 January 2008 13:23:14 Takashi Iwai escreveu: > > At Thu, 24 Jan 2008 13:07:31 -0200, > > > > Herton Ronaldo Krzesinski wrote: > > > Em Tuesday 22 January 2008 12:55:17 Takashi Iwai escreveu: > > > > At Mon, 21 Jan 2008 13:48:20 -0500, > > > > > > > > Marc Boucher wrote: > > > > > Hi Takashi, > > > > > > > > > > Here's the sign-off: > > > > > > > > > > Signed-off-by: Marc Boucher <marc@xxxxxxxxxxxx> > > > > > > > > Thanks! > > > > > > > > > Do you have any specific comments about the code itself? > > > > > > > > I have now applied some parts of your patch to HG tree, namely, > > > > > > > > - laptop model fixes for Cxt5045 > > > > - clean up of Cxt5047 verbs > > > > - add missing input elements for cxt5047 test model > > > > - a workaround in power-state change > > > > - afg and mfg fields in codec preset > > > > - ratelimit to timeout messages > > > > > > > > I modified the above a bit, mainly for fixing coding issues. > > > > So, be careful to rebase your patch again. > > > > > > > > The rest, the addition of cxt5051 and the HSF modem are pending. > > > > > > > > I checked the patch and found some problems in cxt5051 code: > > > > > > > > - the ADC stream may be unswitched even if you plug/unplug the docking > > > > station when the PCM is being opened > > > > - basically the capture switch has no role > > > > - judging the difference of capture prepare/cleanup via the number of > > > > adc > > > > > > > > The patch below is my revised version with some cleanups. > > > > Can someone test with the top of the very latest HG tree (at least > > > > changeset 5753)? > > > > > > Hi, I tested in the HP laptop model we have here. The patch works very > > > well, I only noticed two things: > > > > > > - The PCM slider in alsamixer doesn't have any effect on volume, Master > > > slide does. > > > > The driver has no "PCM" volume. It's a volume for softvol plugin, > > which is used for the "default" PCM. If you access the hardware > > directly via hw layer, it's ignored. > > > > > - In HP laptop model here Docking Mic binds to the external mic and > > > Internal Mic to the builtin mic (it's the only two items in this laptop, > > > External Mic doesn't really exist, I can create another model only for > > > the laptop here to omit External Mic and rename Docking Mic to External > > > Mic, but it's not something important anyway). I noticed just something > > > strange in the automute of the mic inputs: if the volume is not zero for > > > Docking Mic, it doesn't automute Internal Mic, I can capture from both > > > inputs, but if I mute Docking Mic (=0), and plug the mic in Docking Mic, > > > it mutes Internal Mic. > > > > Interesting. Could you once stop/close the capture stream and > > restart recording again when you plug the external mic? Does the same > > effect happen? > > Ops sorry, I made a mistake in the testing here when playing with volumes, > when verifying again I saw everything is ok now, so there are really no > issues. Automute of mics is working properly. Good to hear. I'll try to clean up more a bit before merging. Could you tell me the PCI SSID and the product name of the laptop? thanks, Takashi _______________________________________________ Alsa-devel mailing list Alsa-devel@xxxxxxxxxxxxxxxx http://mailman.alsa-project.org/mailman/listinfo/alsa-devel
