At Thu, 24 Jan 2008 17:13:42 +0200, Andy Shevchenko wrote: > > Hi! > > This is improvement of the early support of the FM-only cards where the > fm801 chip represents the PCI to tuner bridge. > > The tuner initialization isn't included the mute on as well as mute support > via V4L request. Proposed patch should fix this at least for 64-PCR model. Instead of adding noop callbacks, it's better to add a NULL check of tea->ops->mute. That is, something like: if (tea->ops->mute) tea->ops->mute(tea, (v.flags & VIDEO_AUDIO_MUTE) != 0); We don't need to define TEA575X_[UN]MUTE. They are just bool, so use zero and non-zero. Last but not least, please fix the coding style issues reported via $LINUX/scripts/checkpatch.pl. Thanks, Takashi _______________________________________________ Alsa-devel mailing list Alsa-devel@xxxxxxxxxxxxxxxx http://mailman.alsa-project.org/mailman/listinfo/alsa-devel