On 12/18/20 12:45 AM, Kai Vehmanen wrote:
Hey,
I gave a quick test spin and features seems to work as advertized. A few
minor comments on the code. If Jaroslav you think this would be ok as an
approach, I can give a more extensive test run on this.
[snip]
sound-core/
├── card0
│ ├── HDMI!DP,pcm=10 Jack
this combination of "!,= " characters in filenames is a bit non-unixy,
but maybe in 2020 we are ready for this.
OK, will try to remove those characters.
+static void _snd_jack_report(struct snd_jack *jack, int status, bool from_inject)
+{
+ struct snd_jack_kctl *jack_kctl;
[snip]
+ char *tname;
+
+ /* the folder's name can't contains '/', need to replace it with '!' as lib/kobject.c does */
+ tname = kstrdup(jack_kctl->kctl->id.name, GFP_KERNEL);
This goes over 100-column limit and triggers a checkpatch complaint.
Got it, will fix it.
Thanks.
Br, Kai
