On 10/30/2020 3:23 PM, Rojewski, Cezary wrote:
On 2020-10-30 3:54 PM, Amadeusz Sławiński wrote:
Almost all other allocations in ASoC API are resource managed, the only
exception is soc-topology.c.
This patchset clean ups few unnecessary functions in preparation for
change and then changes to devm_ functions for allocation.
These address some of the long standing issues of resource allocation
for topology, thanks for your work.
Nitpick:
*the 0/7* looks weird given that only 6 patches are actually part of the
series.
Yes that was a copy&paste mistake, similarly to already mentioned v3.
There is only 6 patches.
It is a problem caused by manually filling cover letter and copying
title from old cover letter to new one.
I did some reading, and apparently if one operates on branches to
prepare patch sets, they can do something like:
$ git branch --edit-description
$ git format-patch -6 --cover-letter --cover-from-description=subject
And git will automatically populate cover letter with text from branch
description. I will try to remember to try it when sending another
series. Hopefully this will allow me to avoid copy&paste mistakes, as
filling cover letter title and description will be automated ;)
Mark, do let me know if you want me to resend.
For the series:
Reviewed-by: Cezary Rojewski <cezary.rojewski@xxxxxxxxx>
Thanks,
Czarek
Amadeusz Sławiński (6):
ASoC: topology: Remove unused functions from topology API
ASoC: topology: Remove multistep topology loading
ASoC: topology: Unify all device references
ASoC: topology: Change allocations to resource managed
ASoC: topology: Remove empty functions
ASoC: topology: Simplify remove_widget function
include/sound/soc-topology.h | 13 +-
sound/soc/intel/skylake/skl-topology.c | 9 +-
sound/soc/soc-topology.c | 302 +++++--------------------
sound/soc/sof/pcm.c | 2 +-
sound/soc/sof/topology.c | 4 +-
5 files changed, 57 insertions(+), 273 deletions(-)
