On Wed, 2020-10-21 at 14:23 +0100, Mark Brown wrote: > On Wed, Oct 21, 2020 at 04:53:52PM +0800, Jiaxin Yu wrote: > > This patch adds mt8192 platform and affiliated drivers. > > > > Signed-off-by: Jiaxin Yu <jiaxin.yu@xxxxxxxxxxxx> > > --- > > sound/soc/mediatek/Kconfig | 10 + > > sound/soc/mediatek/Makefile | 1 + > > sound/soc/mediatek/common/mtk-afe-fe-dai.c | 13 +- > > sound/soc/mediatek/common/mtk-base-afe.h | 1 + > > sound/soc/mediatek/mt8192/Makefile | 14 + > > sound/soc/mediatek/mt8192/mt8192-afe-clk.c | 669 ++++ > > sound/soc/mediatek/mt8192/mt8192-afe-clk.h | 244 ++ > > sound/soc/mediatek/mt8192/mt8192-afe-common.h | 170 + > > .../soc/mediatek/mt8192/mt8192-afe-control.c | 163 + > > sound/soc/mediatek/mt8192/mt8192-afe-gpio.c | 306 ++ > > sound/soc/mediatek/mt8192/mt8192-afe-gpio.h | 19 + > > sound/soc/mediatek/mt8192/mt8192-afe-pcm.c | 2389 +++++++++++++ > > sound/soc/mediatek/mt8192/mt8192-dai-adda.c | 1489 ++++++++ > > sound/soc/mediatek/mt8192/mt8192-dai-i2s.c | 2139 +++++++++++ > > sound/soc/mediatek/mt8192/mt8192-dai-pcm.c | 409 +++ > > sound/soc/mediatek/mt8192/mt8192-dai-tdm.c | 778 ++++ > > .../mediatek/mt8192/mt8192-interconnection.h | 65 + > > sound/soc/mediatek/mt8192/mt8192-reg.h | 3131 +++++++++++++++++ > > 18 files changed, 12006 insertions(+), 4 deletions(-) > > This is *way* too big to be a single patch, please split it up - it's > over 600K. I will split the dai driver files as a seperate patches. Such as: ASoC: mediatek: mt8192: support adda in platform driver ASoC: mediatek: mt8192: support i2s in platform driver ASoC: mediatek: mt8192: support pcm in platform driver ASoC: mediatek: mt8192: support tdm in platform driver They're still in series of "ASoC: mediatek: mt8192: add platform driver". Is this appropriate? Please correct me if there is any misunderstanding.