Re: [PATCH 00/13] ASoC: Intel: Remove obsolete solutions and

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Sun, Oct 04, 2020 at 12:01:15PM +0200, Cezary Rojewski wrote:
> Follow up to catpt series as mentioned in:
> [PATCH v10 00/14] ASoC: Intel: Catpt - Lynx and Wildcat point
> https://www.spinics.net/lists/alsa-devel/msg116440.html
> 
> As catpt is a direct replacement to sound/soc/intel/haswell, it leaves a
> lot of code redudant. The second legacy solution - baytrail - is
> deprecated for a long time by sound/soc/intel/atom with SOF flavor
> available too.
> 
> This series addresses the redudancy and removes obsolete code. Along
> with the legacy solutions, all orphaned components are removed too.
> 
> As a consequence, further cleanups are unlocked: sound/soc/intel/skylake
> becomes the sole user of processing code found in
> sound/soc/intel/common. Those are not part of this series.

Completely in favour of this series, thanks!
FWIW,
Reviewed-by: Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx>

> Cezary Rojewski (13):
>   ASoC: Intel: Remove haswell solution
>   ASoC: Intel: Remove max98090 support for baytrail solution
>   ASoC: Intel: Remove rt5640 support for baytrail solution
>   ASoC: Intel: Remove baytrail solution
>   ASoC: Intel: Remove SST ACPI component
>   ASoC: Intel: Remove SST firmware components
>   ASoC: Intel: Skylake: Unassign ram_read and read_write ops
>   ASoC: Intel: Remove unused DSP operations
>   ASoC: Intel: Remove unused DSP interface fields
>   ASoC: Intel: Remove SST-legacy specific constants
>   ASoC: Intel: Make atom components independent of sst-dsp
>   ASoC: Intel: Remove sst_pdata structure
>   ASoC: Intel: Remove sst_dsp_get_thread_context
> 
>  include/sound/soc-acpi-intel-match.h          |    1 -
>  include/trace/events/hswadsp.h                |  385 ---
>  sound/soc/intel/Kconfig                       |   26 -
>  sound/soc/intel/Makefile                      |    1 -
>  sound/soc/intel/atom/sst/sst.c                |    1 -
>  sound/soc/intel/atom/sst/sst.h                |    7 +
>  sound/soc/intel/atom/sst/sst_acpi.c           |    1 -
>  sound/soc/intel/atom/sst/sst_drv_interface.c  |    3 -
>  sound/soc/intel/atom/sst/sst_ipc.c            |    1 -
>  sound/soc/intel/atom/sst/sst_loader.c         |    1 -
>  sound/soc/intel/atom/sst/sst_pvt.c            |    1 -
>  sound/soc/intel/atom/sst/sst_stream.c         |    1 -
>  sound/soc/intel/baytrail/Makefile             |    5 -
>  sound/soc/intel/baytrail/sst-baytrail-dsp.c   |  358 ---
>  sound/soc/intel/baytrail/sst-baytrail-ipc.c   |  772 ------
>  sound/soc/intel/baytrail/sst-baytrail-ipc.h   |   64 -
>  sound/soc/intel/baytrail/sst-baytrail-pcm.c   |  459 ----
>  sound/soc/intel/boards/Kconfig                |   25 -
>  sound/soc/intel/boards/Makefile               |    4 -
>  sound/soc/intel/boards/byt-max98090.c         |  182 --
>  sound/soc/intel/boards/byt-rt5640.c           |  224 --
>  sound/soc/intel/boards/bytcht_es8316.c        |    1 -
>  sound/soc/intel/boards/bytcr_rt5640.c         |    1 -
>  sound/soc/intel/common/Makefile               |    4 -
>  .../intel/common/soc-acpi-intel-byt-match.c   |   15 -
>  sound/soc/intel/common/sst-acpi.c             |  236 --
>  sound/soc/intel/common/sst-dsp-priv.h         |  284 +--
>  sound/soc/intel/common/sst-dsp.c              |  162 --
>  sound/soc/intel/common/sst-dsp.h              |  222 --
>  sound/soc/intel/common/sst-firmware.c         | 1273 ----------
>  sound/soc/intel/common/sst-ipc.c              |   27 -
>  sound/soc/intel/common/sst-ipc.h              |    3 -
>  sound/soc/intel/haswell/Makefile              |    5 -
>  sound/soc/intel/haswell/sst-haswell-dsp.c     |  705 ------
>  sound/soc/intel/haswell/sst-haswell-ipc.c     | 2222 -----------------
>  sound/soc/intel/haswell/sst-haswell-ipc.h     |  527 ----
>  sound/soc/intel/haswell/sst-haswell-pcm.c     | 1369 ----------
>  sound/soc/intel/skylake/bxt-sst.c             |    2 -
>  sound/soc/intel/skylake/cnl-sst.c             |    4 +-
>  sound/soc/intel/skylake/skl-sst-dsp.c         |    2 +-
>  sound/soc/intel/skylake/skl-sst-ipc.c         |    2 +-
>  sound/soc/intel/skylake/skl-sst.c             |    2 -
>  42 files changed, 11 insertions(+), 9579 deletions(-)
>  delete mode 100644 include/trace/events/hswadsp.h
>  delete mode 100644 sound/soc/intel/baytrail/Makefile
>  delete mode 100644 sound/soc/intel/baytrail/sst-baytrail-dsp.c
>  delete mode 100644 sound/soc/intel/baytrail/sst-baytrail-ipc.c
>  delete mode 100644 sound/soc/intel/baytrail/sst-baytrail-ipc.h
>  delete mode 100644 sound/soc/intel/baytrail/sst-baytrail-pcm.c
>  delete mode 100644 sound/soc/intel/boards/byt-max98090.c
>  delete mode 100644 sound/soc/intel/boards/byt-rt5640.c
>  delete mode 100644 sound/soc/intel/common/sst-acpi.c
>  delete mode 100644 sound/soc/intel/common/sst-firmware.c
>  delete mode 100644 sound/soc/intel/haswell/Makefile
>  delete mode 100644 sound/soc/intel/haswell/sst-haswell-dsp.c
>  delete mode 100644 sound/soc/intel/haswell/sst-haswell-ipc.c
>  delete mode 100644 sound/soc/intel/haswell/sst-haswell-ipc.h
>  delete mode 100644 sound/soc/intel/haswell/sst-haswell-pcm.c
> 
> -- 
> 2.17.1
> 

-- 
With Best Regards,
Andy Shevchenko





[Index of Archives]     [ALSA User]     [Linux Audio Users]     [Pulse Audio]     [Kernel Archive]     [Asterisk PBX]     [Photo Sharing]     [Linux Sound]     [Video 4 Linux]     [Gimp]     [Yosemite News]

  Powered by Linux