Re: [PATCH 5/6] ASoC: Intel: sof_sdw_rt700: add codec prefix

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Dne 23. 09. 20 v 10:05 Kai Vehmanen napsal(a):
> From: Pierre-Louis Bossart <pierre-louis.bossart@xxxxxxxxxxxxxxx>
> 
> Somehow for this codec we never used any prefix for the controls,
> likely because the test platform has a single SoundWire device.
> 
> Follow the convention and use the codec prefix across the board to
> avoid possible conflicts.
> 
> Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart@xxxxxxxxxxxxxxx>
> Reviewed-by: Bard Liao <yung-chuan.liao@xxxxxxxxxxxxxxx>
> Reviewed-by: Guennadi Liakhovetski <guennadi.liakhovetski@xxxxxxxxxxxxxxx>
> Signed-off-by: Kai Vehmanen <kai.vehmanen@xxxxxxxxxxxxxxx>
> ---
>  sound/soc/intel/boards/sof_sdw_rt700.c | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/sound/soc/intel/boards/sof_sdw_rt700.c b/sound/soc/intel/boards/sof_sdw_rt700.c
> index bff69cfe27f4..21e7e4a81779 100644
> --- a/sound/soc/intel/boards/sof_sdw_rt700.c
> +++ b/sound/soc/intel/boards/sof_sdw_rt700.c
> @@ -23,9 +23,9 @@ static const struct snd_soc_dapm_widget rt700_widgets[] = {
>  
>  static const struct snd_soc_dapm_route rt700_map[] = {
>  	/* Headphones */
> -	{ "Headphones", NULL, "HP" },
> -	{ "Speaker", NULL, "SPK" },
> -	{ "MIC2", NULL, "AMIC" },
> +	{ "Headphones", NULL, "rt700 HP" },
> +	{ "Speaker", NULL, "rt700 SPK" },

> +	{ "rt700 MIC2", NULL, "AMIC" },

This line looks suspicious. Perhaps, the prefix should be added before AMIC ?

						Jaroslav

-- 
Jaroslav Kysela <perex@xxxxxxxx>
Linux Sound Maintainer; ALSA Project; Red Hat, Inc.



[Index of Archives]     [ALSA User]     [Linux Audio Users]     [Pulse Audio]     [Kernel Archive]     [Asterisk PBX]     [Photo Sharing]     [Linux Sound]     [Video 4 Linux]     [Gimp]     [Yosemite News]

  Powered by Linux