On 2020-09-17 4:57 PM, Andy Shevchenko wrote: > On Thu, Sep 17, 2020 at 04:12:28PM +0200, Cezary Rojewski wrote: >> Implement support for Lynxpoint and Wildcat Point AudioDSP. Catpt >> solution deprecates existing sound/soc/intel/haswell which is removed in >> the following series. This cover-letter is followed by 'Developer's deep >> dive' message schedding light on catpt's key concepts and areas >> addressed. >> ... >> >> Changes in v6: >> - reordered and reorganized code for patches 1/13 - 8/13 of v5, so each >> patches makes use of no member or function which is unavailable to it. >> Series size increased from 13 to 14 patches: addition of base members >> e.g.: registers has been split from addition of device.c file which >> describes acpi device behavior > > I like how it looks now from split perspective. > > It misses all the rest either being addressed or commented. Can you comment on > v5 why none of the change is being addressed? > Sorry for the late answers Andy. Technically during such code shuffling (a lot of code has been moved between the patches) one could sneak some stuff which shouldn't be part of this series at all and it would be very hard for reviewers to notice those. So, my approach was to avoid any confusion, any suspicions during such procedure and be transparent. If you diff'ed all the files after applying v5 against everything in v6, you would notice basically no differences. Additional impactful changes can be provided from now on. Czarek
