On Tue, Sep 15, 2020 at 10:26:02AM +0200, Alexandre Belloni wrote: > On 11/09/2020 19:31:40+0200, Miquel Raynal wrote: > > + /* > > + * Enable the fast charging feature and ensure the needed 40ms ellapsed > > + * before using the analog circuits. > > + */ > > + snd_soc_component_write(component, AIC32X4_REFPOWERUP, > > + AIC32X4_REFPOWERUP_40MS); > > + msleep(40); > > + > Maybe the actual REFPOWERUP value could be exposed as a control so > userspace has a way to set the policy? We very rarely do this, there's not usially anything > I'm not sure it make sense to have the delay in probe because it is not > enable the analog part of the codec. The delay should probable be after > the clocks have been set up because the datasheet says that it is mdac > and madc that is starting the analog circuitry. Deferring the delay to a workqueue is the usual thing where there's concerns about slowing down boot.
Attachment:
signature.asc
Description: PGP signature
