On Tue, Aug 25, 2020 at 04:18:21PM +0300, Andy Shevchenko wrote: > On Tue, Aug 25, 2020 at 11:32:57AM +0200, Cezary Rojewski wrote: > > On 2020-08-19 3:43 PM, Andy Shevchenko wrote: > > > On Wed, Aug 19, 2020 at 03:26:04PM +0200, Cezary Rojewski wrote: ... > > > My vision is to extend that header to cover changes and use it in your code. > > > It might, though, require some cleanups to be done against pxa2xx_ssp.h. > > > > Conclusion from checking pxa2_ssp.h registers: > > > > - SSPSP2 is missing (0x44) > > - SSC2 vs SSACDD (0x40) both same offset but different purpose so probably > > new define would have to be added > > > > As situation is similar to the resource-API case below are the options: > > a) ship catpt with existing ssp reg set, update pxa2_ssp.h in following > > series and then re-use them for catpt > > b) update pxa2_ssp.h first, await merge, ship catpt only afterward > > > > I vote for option a) given the maturity driver is reaching plus I'd rather > > be done with sound/soc/intel/ sanitization sooner than later. > > Luckily we have Mark to maintain both SPI and ASoC, which means you may prepend > your series with PXA2xx header update and have his Ack for it. He can create an > immutable branch and apply it to SPI tree afterwards, or other way around. So I > definitely vote for b). Let's say "for b+)" mean the fast track of the changes to both subsystems. -- With Best Regards, Andy Shevchenko