Re: [PATCH] hda: STAC927x DMIC Cleanup

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 12/17/07, Takashi Iwai <tiwai@xxxxxxx> wrote:
> At Fri, 14 Dec 2007 15:02:40 -0500,
> Matthew Ranostay wrote:
> >
> > @@ -1408,22 +1409,24 @@ static unsigned int dell_3st_pin_configs
> >  static unsigned int dell_3st_pin_configs[14] = {
> >       0x02211230, 0x02a11220, 0x01a19040, 0x01114210,
> >       0x01111212, 0x01116211, 0x01813050, 0x01112214,
> > -     0x403003fa, 0x40000100, 0x40000100, 0x404003fb,
> > +     0x403003fa, 0x90a60040, 0x90a60040, 0x404003fb,
> >       0x40c003fc, 0x40000100
> >  };
>
> Just to be sure - is it safe to change this?
>
> > @@ -3293,8 +3304,11 @@ static int patch_stac927x(struct hda_cod
> >                                                       stac927x_models,
> >                                                       stac927x_cfg_tbl);
> >   again:
> > -     if (spec->board_config < 0) {
> > -                snd_printdd(KERN_INFO "hda_codec: Unknown model for STAC927x, using BIOS defaults\n");
> > +     if (spec->board_config < 0 ||
> > +         stac927x_brd_tbl[spec->board_config] != NULL) {
>
> Should be stac927x_brd_tbl[spec->board_config] == NULL.
> Also, the following else-if should be fixed (the check is nonsense).
>
> I applied the fixed patch to HG tree.  Could you check whether it's
> OK?
>

I am on DELL Vostro 1400 and now the sound and headphones jack work
nicely out of the box. Unfortunately the built-in microphone still
doesn't work. I have 3 capture devices which isn't right I think. I am
attaching codec info and amixser outputs.

>
> Thanks,
>
> Takashi
> _______________________________________________
> Alsa-devel mailing list
> Alsa-devel@xxxxxxxxxxxxxxxx
> http://mailman.alsa-project.org/mailman/listinfo/alsa-devel
>


-- 
Ivan N. Zlatev

Web: http://www.i-nZ.net
"It's all some kind of whacked out conspiracy."

Attachment: amixer-output
Description: Binary data

Attachment: codec-0
Description: Binary data

_______________________________________________
Alsa-devel mailing list
Alsa-devel@xxxxxxxxxxxxxxxx
http://mailman.alsa-project.org/mailman/listinfo/alsa-devel

[Index of Archives]     [ALSA User]     [Linux Audio Users]     [Kernel Archive]     [Asterisk PBX]     [Photo Sharing]     [Linux Sound]     [Video 4 Linux]     [Gimp]     [Yosemite News]

  Powered by Linux