Re: [PATCH 07/11] ASoC: q6asm: add support to gapless flag in asm open

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 




Thanks Pierre for review,

On 07/07/2020 17:57, Pierre-Louis Bossart wrote:

diff --git a/sound/soc/qcom/qdsp6/q6asm-dai.c b/sound/soc/qcom/qdsp6/q6asm-dai.c
index c3558288242a..8c214436a2c2 100644
--- a/sound/soc/qcom/qdsp6/q6asm-dai.c
+++ b/sound/soc/qcom/qdsp6/q6asm-dai.c
@@ -258,7 +258,7 @@ static int q6asm_dai_prepare(struct snd_soc_component *component,
      if (substream->stream == SNDRV_PCM_STREAM_PLAYBACK) {
          ret = q6asm_open_write(prtd->audio_client, prtd->stream_id,
                         FORMAT_LINEAR_PCM,
-                       0, prtd->bits_per_sample);
+                       0, prtd->bits_per_sample, false);

nit-pick: it's a bit ironic that is_gapless is false for PCM, when there is no gap in the first place..

I think this is to do with same apis reused for both compressed and pcm.

Probably we can live with it for now!

--srini

      } else if (substream->stream == SNDRV_PCM_STREAM_CAPTURE) {
          ret = q6asm_open_read(prtd->audio_client, prtd->stream_id,
                        FORMAT_LINEAR_PCM,
@@ -685,7 +685,7 @@ static int q6asm_dai_compr_set_params(struct snd_soc_component *component,
      if (dir == SND_COMPRESS_PLAYBACK) {
          ret = q6asm_open_write(prtd->audio_client, prtd->stream_id,
                         params->codec.id, params->codec.profile,
-                       prtd->bits_per_sample);
+                       prtd->bits_per_sample, true);



[Index of Archives]     [ALSA User]     [Linux Audio Users]     [Pulse Audio]     [Kernel Archive]     [Asterisk PBX]     [Photo Sharing]     [Linux Sound]     [Video 4 Linux]     [Gimp]     [Yosemite News]

  Powered by Linux