Re: [PATCH 03/11] ASoC: q6asm: make commands specific to streams

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Thanks Pierre for quick review,

On 07/07/2020 17:52, Pierre-Louis Bossart wrote:



@@ -184,8 +186,8 @@ static void event_handler(uint32_t opcode, uint32_t token,
      switch (opcode) {
      case ASM_CLIENT_EVENT_CMD_RUN_DONE:
          if (substream->stream == SNDRV_PCM_STREAM_PLAYBACK)
-            q6asm_write_async(prtd->audio_client,
-                   prtd->pcm_count, 0, 0, NO_TIMESTAMP);
+            q6asm_write_async(prtd->audio_client, prtd->stream_id,
+                   prtd->pcm_count, 0, 0, 0);

sound/soc/qcom/qdsp6/q6asm.h:#define NO_TIMESTAMP    0xFF00

is the change on the previous line intentional?

May be not!

Plan is that the users of these apis will send flags directly instead of boiler plating this!

This change should go as part of next patch("[PATCH 04/11] ASoC: q6asm: use flags directly from asm-dai") which would make it much clear!

thanks,
srini



[Index of Archives]     [ALSA User]     [Linux Audio Users]     [Pulse Audio]     [Kernel Archive]     [Asterisk PBX]     [Photo Sharing]     [Linux Sound]     [Video 4 Linux]     [Gimp]     [Yosemite News]

  Powered by Linux