On 5/6/20 11:43 AM, Mark Brown wrote:
On Wed, May 06, 2020 at 04:33:00PM +0000, Mukunda, Vijendar wrote:
+config SND_SOC_AMD_RENOIR_MACH
+ tristate "AMD Renoir support for DMIC"
+ select SND_SOC_DMIC
there could be a missing dependency if GPIOLIB is not selected
(SND_SOC_DMIC
depends on it).
That dependency is wrong, DMICs don't need GPIOs so while a given system
might need DMIC the code should be fine with the stub gpiolib
implementation. It will mean it won't work on some boards though.
For our current implementation, we don't have any GPIOLIB dependency.
We just need a generic DMIC driver which should provide codec dai for
sound card registration.
What you've got should be fine then, you should test with a !GPIOLIB
build just to be sure though and ideally submit a patch fixing the
SND_SOC_DMIC Kconfig.
if you don't care about gpios, then the only reason to use the dmic
codec would be the modeswitch and wakeup delays properties. If you don't
care then a dummy codec would be just fine.
