[AMD Official Use Only - Internal Distribution Only] > -----Original Message----- > From: Mark Brown <broonie@xxxxxxxxxx> > Sent: Wednesday, May 6, 2020 9:57 PM > To: Pierre-Louis Bossart <pierre-louis.bossart@xxxxxxxxxxxxxxx> > Cc: Alex Deucher <alexdeucher@xxxxxxxxx>; alsa-devel@xxxxxxxxxxxxxxxx; > Mukunda, Vijendar <Vijendar.Mukunda@xxxxxxx>; tiwai@xxxxxxx; Deucher, > Alexander <Alexander.Deucher@xxxxxxx> > Subject: Re: [PATCH 14/14] ASoC: amd: enable build for RN machine driver > > On Tue, May 05, 2020 at 04:39:37PM -0500, Pierre-Louis Bossart wrote: > > > > +config SND_SOC_AMD_RENOIR_MACH > > > + tristate "AMD Renoir support for DMIC" > > > + select SND_SOC_DMIC > > > there could be a missing dependency if GPIOLIB is not selected > (SND_SOC_DMIC > > depends on it). > > That dependency is wrong, DMICs don't need GPIOs so while a given system > might need DMIC the code should be fine with the stub gpiolib > implementation. It will mean it won't work on some boards though. For our current implementation, we don't have any GPIOLIB dependency. We just need a generic DMIC driver which should provide codec dai for sound card registration.
