> -----Original Message----- > From: Takashi Iwai <tiwai@xxxxxxx> > Sent: Tuesday, April 7, 2020 3:51 PM > To: Kailang <kailang@xxxxxxxxxxx> > Cc: (alsa-devel@xxxxxxxxxxxxxxxx) <alsa-devel@xxxxxxxxxxxxxxxx> > Subject: Re: New HP mute led feature > > On Tue, 07 Apr 2020 09:05:49 +0200, > Kailang wrote: > > > > Hi Takashi, > > > > I modified as attaches. > > Thanks. They had, however, a few typos that didn't compile, so I applied > them with corrections. > Please check the commits in sound git tree later. Thanks a lot. ^^ > > > Takashi > > > > > BR, > > Kailang > > > > > -----Original Message----- > > > From: Takashi Iwai <tiwai@xxxxxxx> > > > Sent: Wednesday, April 1, 2020 2:18 PM > > > To: Kailang <kailang@xxxxxxxxxxx> > > > Cc: (alsa-devel@xxxxxxxxxxxxxxxx) <alsa-devel@xxxxxxxxxxxxxxxx> > > > Subject: Re: New HP mute led feature > > > > > > On Wed, 01 Apr 2020 07:37:50 +0200, > > > Kailang wrote: > > > > > > > > Hi Takashi, > > > > > > > > HP had new mute led feature. > > > > Attach two patches will enable it. > > > > > > They don't seem applied cleanly. > > > Could you rebase to the latest git tree? > > > > > > Also, it might be worth unifying the handling. Both patches > > > introduce very similar functions, and the values to mask and set can be > referred, e.g. > > > spec->coefbit_mask, etc. But such a cleanup can be done in a > > > spec->separate patch > > > later, too. > > > > > > > > > thanks, > > > > > > Takashi > > > > > > ------Please consider the environment before printing this e-mail. > > [2 0001-hp-thinclient-0x877a-mute-led.patch <application/octet-stream > > (base64)>] > > > > [3 0002-hp-thinclient-0x877d-mute-led.patch <application/octet-stream > > (base64)>] > >
