On Wed, 01 Apr 2020 07:37:50 +0200, Kailang wrote: > > Hi Takashi, > > HP had new mute led feature. > Attach two patches will enable it. They don't seem applied cleanly. Could you rebase to the latest git tree? Also, it might be worth unifying the handling. Both patches introduce very similar functions, and the values to mask and set can be referred, e.g. spec->coefbit_mask, etc. But such a cleanup can be done in a separate patch later, too. thanks, Takashi