On 2020-03-10 17:03, Pierre-Louis Bossart wrote:
I didn't actually look at the patches since by the time I went to look
at them it was clear that there was going to be a new version. Pierre
was saying that they added new functionality which would generally not
be suitable.
I am ok with the patches, as long as "[PATCH 5/7] ASoC: Intel:
skl_hda_dsp: Enable Dmic configuration" is dropped as discussed.
I don't know if that requires a v2 or if Mark you can just drop this one
patch?
So for all Patches except Patch5:
Reviewed-by: Pierre-Louis Bossart <pierre-louis.bossart@xxxxxxxxxxxxxxx>
Thanks Cezary!
Thanks for quick review and upstream!
In fact, I wasn't even able to append missing 'Fixes' here and there.
While indeed on 4.19 hdadsp machine driver does not exist so these
patches can count as "new feature", for some other kernels such as 5.4
that ain't a case.
Not very familiar with the cherry-pick mechanism for stable kernels, but
is it possible for patches that ain't flagged with 'Fixes' tag to get
backported? Having all of these at least on 5.4 is in my opinion desirable.
Czarek
