But a more pressing issue is that this breaks platforms using SOF firmware: [ 28.751756] skl_hda_dsp_generic skl_hda_dsp_generic: ASoC: no sink widget found for dmic01_hifi [ 28.751987] skl_hda_dsp_generic skl_hda_dsp_generic: ASoC: Failed to add route DMIC01 Rx -> direct -> dmic01_hifi ... maybe you can align the topology to mathc so we can reuse the same widget mapping for both SOF and SST firmwares..?
Yeah, I thought this would break userspace and installed topologies and that just confirms it. Adding hard-coded routes is really not recommended.
the alternate solution is what I suggested in another thread "No sound since 5.4 on skl_n88l25_s4567", we could mark this machine driver as having an incomplete topology and remove the topology checks in the core.
I couldn't really test my initial patch but that that Cezary unintentionally broke SOF actually that gives me a tool to test the solution.
