Hey,
On Thu, 5 Mar 2020, Cezary Rojewski wrote:
> --- a/sound/soc/intel/boards/skl_hda_dsp_generic.c
> +++ b/sound/soc/intel/boards/skl_hda_dsp_generic.c
> @@ -59,6 +59,9 @@ static const struct snd_soc_dapm_route skl_hda_map[] = {
> { "Digital CPU Capture", NULL, "Digital Codec Capture" },
> { "codec2_in", NULL, "Alt Analog CPU Capture" },
> { "Alt Analog CPU Capture", NULL, "Alt Analog Codec Capture" },
> +
> + { "dmic01_hifi", NULL, "DMIC01 Rx" },
> + { "DMIC01 Rx", NULL, "DMIC AIF" },
hmm, we need to figure out something else for this. This very same table
already has:
» /* digital mics */
» {"DMic", NULL, "SoC DMIC"},
.. so now we have dmic entries two times in the same initializer list.
But a more pressing issue is that this breaks platforms using SOF
firmware:
[ 28.751756] skl_hda_dsp_generic skl_hda_dsp_generic: ASoC: no sink widget found for dmic01_hifi
[ 28.751987] skl_hda_dsp_generic skl_hda_dsp_generic: ASoC: Failed to add route DMIC01 Rx -> direct -> dmic01_hifi
... maybe you can align the topology to mathc so we can reuse the same
widget mapping for both SOF and SST firmwares..?
Br, Kai
