________________________________ From: Mark Brown <broonie@xxxxxxxxxx> Sent: Tuesday 21 January 2020, 10:38 PM To: RAVULAPATI, VISHNU VARDHAN RAO Cc: Deucher, Alexander; Liam Girdwood; Jaroslav Kysela; Takashi Iwai; Mukunda, Vijendar; Colin Ian King; YueHaibing; Kuninori Morimoto; moderated list:SOUND - SOC LAYER / DYNAMIC AUDIO POWER MANAGEM...; open list Subject: Re: [PATCH] ASoC: amd: Fix for Subsequent Playback issue. On Tue, Jan 21, 2020 at 05:03:43PM +0000, RAVULAPATI, VISHNU VARDHAN RAO wrote: > > + kfree(rtd); > This free looks like a separate change which seems good and useful but > should be in a separate patch? > No Mark, > That is part of the fix. please let this be included in this patch. In what way is it part of the fix? This at least needs some sort of explanation somewhere, the changelog at least if not the code. When we play subsequently we hear last played sound for moment.kfree clears the structure. Thanks, Vishnu _______________________________________________ Alsa-devel mailing list Alsa-devel@xxxxxxxxxxxxxxxx https://mailman.alsa-project.org/mailman/listinfo/alsa-devel