[AMD Official Use Only - Internal Distribution Only] ________________________________ From: Mark Brown <broonie@xxxxxxxxxx> Sent: Tuesday 21 January 2020, 10:29 PM To: RAVULAPATI, VISHNU VARDHAN RAO Cc: Deucher, Alexander; Liam Girdwood; Jaroslav Kysela; Takashi Iwai; Mukunda, Vijendar; Colin Ian King; YueHaibing; Kuninori Morimoto; moderated list:SOUND - SOC LAYER / DYNAMIC AUDIO POWER MANAGEM...; open list Subject: Re: [PATCH] ASoC: amd: Fix for Subsequent Playback issue. On Tue, Jan 21, 2020 at 04:13:35PM +0530, Ravulapati Vishnu vardhan rao wrote: > If we play audio back to back, which kills one playback > and immediately start another, we can hear clicks. > This patch fixes the issue. > /* Disable ACP irq, when the current stream is being closed and > * another stream is also not active. > */ > + kfree(rtd); This free looks like a separate change which seems good and useful but should be in a separate patch? No Mark, That is part of the fix. please let this be included in this patch. Thanks for your cooperation. Regards, Vishnu _______________________________________________ Alsa-devel mailing list Alsa-devel@xxxxxxxxxxxxxxxx https://mailman.alsa-project.org/mailman/listinfo/alsa-devel