Re: [PATCH RFC v2 0/4] ASoC: Add Multi CPU DAI support

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 





After this series of patches is applied, we have this in soc.h:

	struct snd_soc_dai *codec_dai;
	struct snd_soc_dai *cpu_dai;

	struct snd_soc_dai **codec_dais;
	unsigned int num_codecs;

	struct snd_soc_dai **cpu_dais;
	unsigned int num_cpus;

What is the intent behind keeping the two fields codec_dai and cpu_dai?

Shouldn't we use the multi-dai structures in all cases, possible
degraded to a single element rather than maintaining what looks like
duplicate ways of accessing the same element?

If removing these fields across all drivers is just too invasive for
now, shouldn't we start defining access macros so that those fields
can be deprecated and removed at a later time, platform-by-platform?

Actually, I have this patch (= remove cpu_dai/codec_dai from all drivers,
and use macro for it), and have plan to post it.

But, I have many extra cleanup patches in my tree,
and I want to post it before that
(to avoid extra re-ordering dpendency break).

ok, thanks for the precisions!
_______________________________________________
Alsa-devel mailing list
Alsa-devel@xxxxxxxxxxxxxxxx
https://mailman.alsa-project.org/mailman/listinfo/alsa-devel



[Index of Archives]     [ALSA User]     [Linux Audio Users]     [Pulse Audio]     [Kernel Archive]     [Asterisk PBX]     [Photo Sharing]     [Linux Sound]     [Video 4 Linux]     [Gimp]     [Yosemite News]

  Powered by Linux